Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-4-lts: [TT-10826] self trim oAuth sorted set (#5907) #5916

Conversation

buger
Copy link
Member

@buger buger commented Dec 29, 2023

TT-10826 self trim oAuth sorted set (#5907)

Description

Add a background job to self trim oAuth sorted set

Related Issue

https://tyktech.atlassian.net/browse/TT-10826

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why

Co-authored-by: Tit Petric tit.petric@monotek.net
Co-authored-by: Tit Petric tit@tyk.io

<!-- Provide a general summary of your changes in the Title above -->

Add a background job to self trim oAuth sorted set

https://tyktech.atlassian.net/browse/TT-10826

<!-- Why is this change required? What problem does it solve? -->

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

---------

Co-authored-by: Tit Petric <tit.petric@monotek.net>
Co-authored-by: Tit Petric <tit@tyk.io>

(cherry picked from commit ee5dc29)
Copy link

sweep-ai bot commented Dec 29, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

sweep-ai bot commented Dec 29, 2023

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run go build .
yielded the following error:
##[error]Process completed with exit code 1.

Here are the logs:
go: errors parsing go.mod:
/home/runner/work/tyk/tyk/go.mod:112: unknown directive: <<<<<<<
/home/runner/work/tyk/tyk/go.mod:115: unknown directive: =======
/home/runner/work/tyk/tyk/go.mod:249: unknown directive: >>>>>>>

Copy link

sweep-ai bot commented Dec 29, 2023

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run ./bin/ci-tests.sh
yielded the following error:
##[error]Process completed with exit code 1.

Here are the logs:
go: errors parsing go.mod:
/home/runner/work/tyk/tyk/go.mod:112: unknown directive: <<<<<<<
/home/runner/work/tyk/tyk/go.mod:115: unknown directive: =======
/home/runner/work/tyk/tyk/go.mod:249: unknown directive: >>>>>>>
go: errors parsing go.mod:
/home/runner/work/tyk/tyk/go.mod:112: unknown directive: <<<<<<<
/home/runner/work/tyk/tyk/go.mod:115: unknown directive: =======
/home/runner/work/tyk/tyk/go.mod:249: unknown directive: >>>>>>>
building Go-plugin failed

Copy link

sweep-ai bot commented Dec 29, 2023

Sweeping

Fixing PR: track the progress here.

I'm currently fixing this PR to address the following:

[Sweep GHA Fix] The GitHub Actions run failed with the following error logs:

The command:
Run export GOPATH=/go
yielded the following error:
##[error]Process completed with exit code 1.
##[group]Run export GOPATH=/go
�[36;1mexport GOPATH=/go�[0m
�[36;1mmkdir -p /go/src || true�[0m
�[36;1mwhereis go�[0m
�[36;1mgo mod tidy�[0m
�[36;1mgo mod vendor�[0m
�[36;1mecho "Moving vendor"�[0m
�[36;1mcp -r -f vendor/* $GOPATH/src�[0m
�[36;1mrm -rf vendor�[0m
�[36;1mmkdir -p /go/src/github.com/TykTechnologies/tyk�[0m
�[36;1mcp -r ./* /go/src/github.com/TykTechnologies/tyk�[0m
shell: sh -e {0}
env:
  SLACK_CLI_TOKEN: ***
  GOPRIVATE: github.com/TykTechnologies
##[endgroup]
go: /usr/local/go /usr/local/go/bin/go
go: errors parsing go.mod:
/__w/tyk/tyk/go.mod:112: unknown directive: <<<<<<<
/__w/tyk/tyk/go.mod:115: unknown directive: =======
/__w/tyk/tyk/go.mod:249: unknown directive: >>>>>>>
##[error]Process completed with exit code 1.

Here are the logs:
go: /usr/local/go /usr/local/go/bin/go
go: errors parsing go.mod:
/__w/tyk/tyk/go.mod:112: unknown directive: <<<<<<<
/__w/tyk/tyk/go.mod:115: unknown directive: =======
/__w/tyk/tyk/go.mod:249: unknown directive: >>>>>>>

@buger
Copy link
Member Author

buger commented Dec 29, 2023

API tests result: failure 🚫
Branch used: refs/pull/5916/merge
Commit:
Triggered by: pull_request (@buger)
Execution page

@jeffy-mathew jeffy-mathew marked this pull request as ready for review December 29, 2023 11:30
@buger
Copy link
Member Author

buger commented Dec 29, 2023

API tests result: success
Branch used: refs/pull/5916/merge
Commit: e4b09bb
Triggered by: pull_request (@jeffy-mathew)
Execution page

@buger
Copy link
Member Author

buger commented Dec 29, 2023

API tests result: success
Branch used: refs/pull/5916/merge
Commit: 2656183
Triggered by: pull_request (@jeffy-mathew)
Execution page

@buger
Copy link
Member Author

buger commented Dec 29, 2023

API tests result: success
Branch used: refs/pull/5916/merge
Commit: 107d13c
Triggered by: pull_request (@jeffy-mathew)
Execution page

@jeffy-mathew jeffy-mathew enabled auto-merge (squash) December 29, 2023 12:02
@jeffy-mathew jeffy-mathew merged commit 29dee33 into release-4-lts Dec 29, 2023
5 checks passed
@jeffy-mathew jeffy-mathew deleted the merge/release-4-lts/ee5dc29b6254e94a06eacd88ca060d6fd0e7a1bf branch December 29, 2023 12:03
@buger
Copy link
Member Author

buger commented Dec 29, 2023

API tests result: success
Branch used: refs/pull/5916/merge
Commit: 3470331
Triggered by: pull_request (@jeffy-mathew)
Execution page

@buger
Copy link
Member Author

buger commented Dec 29, 2023

API tests result: success
Branch used: refs/heads/release-4-lts
Commit: 29dee33 Merging to release-4-lts: TT-10826 self trim oAuth sorted set (#5907) (#5916)

TT-10826 self trim oAuth sorted set (#5907)

Description

Add a background job to self trim oAuth sorted set

Related Issue

https://tyktech.atlassian.net/browse/TT-10826

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)
  • Refactoring or add test (improvements in base code or adds test
    coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning
    why it's required
  • I would like a code coverage CI quality gate exception and have
    explained why

Co-authored-by: Tit Petric tit.petric@monotek.net
Co-authored-by: Tit Petric tit@tyk.io


Co-authored-by: Jeffy Mathew jeffy.mathew100@gmail.com
Triggered by: push (@jeffy-mathew)
Execution page

lghiur pushed a commit that referenced this pull request Jan 22, 2024
… (#5916)

[TT-10826] self trim oAuth sorted set (#5907)

<!-- Provide a general summary of your changes in the Title above -->

## Description
Add a background job to self trim oAuth sorted set

## Related Issue
https://tyktech.atlassian.net/browse/TT-10826
## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why

---------

Co-authored-by: Tit Petric <tit.petric@monotek.net>
Co-authored-by: Tit Petric <tit@tyk.io>

[TT-10826]:
https://tyktech.atlassian.net/browse/TT-10826?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: Jeffy Mathew <jeffy.mathew100@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants